Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable caching on integration tests #899

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Sep 8, 2023

see title.

@toddbaert toddbaert requested a review from a team as a code owner September 8, 2023 17:02
@toddbaert toddbaert marked this pull request as draft September 8, 2023 17:02
@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 4be0632
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/64fb5c0e1a1c9c00085d6c38

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #899 (ae44311) into main (ebb543d) will not change coverage.
The diff coverage is n/a.

❗ Current head ae44311 differs from pull request most recent head 4be0632. Consider uploading reports for the commit 4be0632 to get more accurate results

@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   72.73%   72.73%           
=======================================
  Files          28       28           
  Lines        2857     2857           
=======================================
  Hits         2078     2078           
  Misses        683      683           
  Partials       96       96           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert toddbaert changed the title wip chore: disable caching on integration tests Sep 8, 2023
@toddbaert toddbaert force-pushed the chore/e2e-verbosity branch 2 times, most recently from faddc6b to 834793f Compare September 8, 2023 17:28
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for disabling cache and making validation strict

Signed-off-by: Todd Baert <[email protected]>
@toddbaert toddbaert marked this pull request as ready for review September 8, 2023 17:40
@toddbaert toddbaert merged commit 16dd21e into main Sep 8, 2023
12 checks passed
@toddbaert toddbaert deleted the chore/e2e-verbosity branch September 8, 2023 17:46
@github-actions github-actions bot mentioned this pull request Sep 8, 2023
Kavindu-Dodan pushed a commit that referenced this pull request Sep 8, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.6.5</summary>

##
[0.6.5](flagd/v0.6.4...flagd/v0.6.5)
(2023-09-08)


### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.6.4
([#880](#880))
([ebb543d](ebb543d))
* **deps:** update opentelemetry-go monorepo
([#868](#868))
([d48317f](d48317f))


### 🧹 Chore

* disable caching on integration tests
([#899](#899))
([16dd21e](16dd21e))
* upgrade to go 1.20
([#891](#891))
([977167f](977167f))
</details>

<details><summary>flagd-proxy: 0.2.10</summary>

##
[0.2.10](flagd-proxy/v0.2.9...flagd-proxy/v0.2.10)
(2023-09-08)


### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.6.4
([#880](#880))
([ebb543d](ebb543d))
* **deps:** update opentelemetry-go monorepo
([#868](#868))
([d48317f](d48317f))


### 🧹 Chore

* upgrade to go 1.20
([#891](#891))
([977167f](977167f))
</details>

<details><summary>core: 0.6.5</summary>

##
[0.6.5](core/v0.6.4...core/v0.6.5)
(2023-09-08)


### 🐛 Bug Fixes

* **deps:** update module github.com/rs/cors to v1.10.0
([#893](#893))
([fe61fbe](fe61fbe))
* **deps:** update module golang.org/x/crypto to v0.13.0
([#888](#888))
([1a9037a](1a9037a))
* **deps:** update module golang.org/x/net to v0.15.0
([#889](#889))
([233d976](233d976))
* **deps:** update module google.golang.org/grpc to v1.58.0
([#896](#896))
([853b76d](853b76d))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.16.1
([#882](#882))
([ca3d85a](ca3d85a))
* **deps:** update opentelemetry-go monorepo
([#868](#868))
([d48317f](d48317f))


### 🧹 Chore

* upgrade to go 1.20
([#891](#891))
([977167f](977167f))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants