feat(flagd): custom error handling for OTel errors #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
odubajDT
approved these changes
Jul 26, 2023
beeme1mr
approved these changes
Jul 26, 2023
Signed-off-by: Giovanni Liva <[email protected]>
toddbaert
approved these changes
Jul 27, 2023
Merged
toddbaert
pushed a commit
that referenced
this pull request
Jul 27, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.6.1</summary> ## [0.6.1](flagd/v0.6.0...flagd/v0.6.1) (2023-07-27) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/go-sdk-contrib/tests/flagd to v1.2.3 ([#749](#749)) ([cd63e48](cd63e48)) </details> <details><summary>flagd-proxy: 0.2.6</summary> ## [0.2.6](flagd-proxy/v0.2.5...flagd-proxy/v0.2.6) (2023-07-27) ### ✨ New Features * **flagd-proxy:** introduce zero-downtime ([#752](#752)) ([ed5e6e5](ed5e6e5)) </details> <details><summary>core: 0.6.1</summary> ## [0.6.1](core/v0.6.0...core/v0.6.1) (2023-07-27) ### 🐛 Bug Fixes * **deps:** update kubernetes packages to v0.27.4 ([#756](#756)) ([dcc10f3](dcc10f3)) * **deps:** update module github.com/bufbuild/connect-go to v1.10.0 ([#771](#771)) ([c74103f](c74103f)) * **deps:** update module google.golang.org/grpc to v1.57.0 ([#773](#773)) ([be8bf04](be8bf04)) ### ✨ New Features * **flagd-proxy:** introduce zero-downtime ([#752](#752)) ([ed5e6e5](ed5e6e5)) * **flagd:** custom error handling for OTel errors ([#769](#769)) ([bda1a92](bda1a92)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #765
Notes
I decided to use a Debug level for OTel error logs given the context provided by #765. They will be visible iff the
-xflag is set.