refactor: simplify connect Resolve... funcs #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyerus
requested review from
AlexsJones,
james-milligan,
toddbaert and
Kavindu-Dodan
as code owners
skyerus
force-pushed
the
issue-385/refactor-connect_service
branch
from
607076e to
38905db
Compare
|
Overall looks good 👍 |
skyerus
force-pushed
the
issue-385/refactor-connect_service
branch
from
bd525c5 to
12b2b4b
Compare
skyerus
force-pushed
the
issue-385/refactor-connect_service
branch
from
12b2b4b to
1306ebe
Compare
Kavindu-Dodan
approved these changes
Feb 9, 2023
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
skyerus
force-pushed
the
issue-385/refactor-connect_service
branch
from
1306ebe to
18fd700
Compare
Codecov Report
@@ Coverage Diff @@
## main #391 +/- ##
=======================================
Coverage ? 63.43%
=======================================
Files ? 10
Lines ? 1195
Branches ? 0
=======================================
Hits ? 758
Misses ? 387
Partials ? 50 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #385
Notes
Follow-up Tasks
How to test
Tested against integration tests.