refactor: isolate flag state management to store #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyerus
requested review from
AlexsJones,
james-milligan and
toddbaert
as code owners
james-milligan
approved these changes
Feb 7, 2023
|
Please quickly review the high-level architecture and make sure it doesn't need to be updated. |
skyerus
force-pushed
the
issue-371_isolate-flag-store
branch
from
fc6b458 to
7c65a98
Compare
Updated! |
Updates also look good per my view |
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
skyerus
force-pushed
the
issue-371_isolate-flag-store
branch
from
7c65a98 to
c2766f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #371
Notes
Follow-up Tasks
How to test
I've ran flagd's integration tests against this build to ensure behaviour is as before.