-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace character slice with regex replace #250
Conversation
These changes also mean that we no longer need to cc @vadasambar |
Thank you and yes, we can replace |
Signed-off-by: James Milligan <[email protected]>
Signed-off-by: James Milligan <[email protected]>
Signed-off-by: James Milligan <[email protected]>
Signed-off-by: James Milligan <[email protected]>
Signed-off-by: James Milligan <[email protected]>
Signed-off-by: James Milligan <[email protected]>
Signed-off-by: James Milligan <[email protected]>
🤖 I have created a release *beep* *boop* --- ## [0.3.1](v0.3.0...v0.3.1) (2023-01-12) ### Features * file extension detection ([#257](#257)) ([ca22541](ca22541)) * ResolveAll endpoint for bulk evaluation ([#239](#239)) ([6437c43](6437c43)) ### Bug Fixes * **deps:** update module github.com/bufbuild/connect-go to v1.4.1 ([#268](#268)) ([712d7dd](712d7dd)) * **deps:** update module github.com/mattn/go-colorable to v0.1.13 ([#260](#260)) ([5b11504](5b11504)) * **deps:** update module github.com/open-feature/open-feature-operator to v0.2.23 ([#261](#261)) ([a1dd3b9](a1dd3b9)) * **deps:** update module github.com/rs/cors to v1.8.3 ([#264](#264)) ([0e6f2f3](0e6f2f3)) * **deps:** update module github.com/stretchr/testify to v1.8.1 ([#265](#265)) ([2ec61c6](2ec61c6)) * improve invalid sync URI errror msg ([#252](#252)) ([5939870](5939870)) * replace character slice with regex replace ([#250](#250)) ([c92d101](c92d101)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: James Milligan [email protected]
This PR
Related Issues
#244
Notes
switches from a hard coded
1:n-2
slice to use regex to match and replace the first{
and last}
in the string.Follow-up Tasks
How to test