Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: renaming of evaluation components #1064

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

bacherfl
Copy link
Contributor

@bacherfl bacherfl commented Dec 7, 2023

This PR improves the naming of the evaluation components. Changes made:

  • Renamed eval package to evaluator
  • Removed the Evaluation/Evaluator suffixes of structs within the evaluator package

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit a99ccaa
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/657b73943581570008cbaa5f

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c86dff0) 72.83% compared to head (a99ccaa) 72.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
+ Coverage   72.83%   72.93%   +0.10%     
==========================================
  Files          31       31              
  Lines        2864     2864              
==========================================
+ Hits         2086     2089       +3     
+ Misses        672      670       -2     
+ Partials      106      105       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bacherfl bacherfl marked this pull request as ready for review December 7, 2023 11:25
@bacherfl bacherfl requested a review from a team as a code owner December 7, 2023 11:25
@Kavindu-Dodan Kavindu-Dodan force-pushed the chore/refactor-evaluators branch from 417a567 to 271c726 Compare December 12, 2023 19:16
@toddbaert toddbaert self-requested a review December 14, 2023 21:30
@toddbaert toddbaert merged commit d39f31d into open-feature:main Dec 14, 2023
14 checks passed
@github-actions github-actions bot mentioned this pull request Dec 14, 2023
toddbaert pushed a commit that referenced this pull request Dec 22, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.8.0</summary>

##
[0.8.0](flagd/v0.7.2...flagd/v0.8.0)
(2023-12-22)


### ⚠ BREAKING CHANGES

* remove deprecated flags
([#1075](#1075))

### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.7.2
([#1056](#1056))
([81e83ea](81e83ea))
* **deps:** update module github.com/spf13/viper to v1.18.0
([#1060](#1060))
([9dfa689](9dfa689))


### 🧹 Chore

* refactoring component structure
([#1044](#1044))
([0c7f78a](0c7f78a))
* remove deprecated flags
([#1075](#1075))
([49f6fe5](49f6fe5))
</details>

<details><summary>flagd-proxy: 0.4.0</summary>

##
[0.4.0](flagd-proxy/v0.3.2...flagd-proxy/v0.4.0)
(2023-12-22)


### ⚠ BREAKING CHANGES

* remove deprecated flags
([#1075](#1075))

### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.7.2
([#1056](#1056))
([81e83ea](81e83ea))
* **deps:** update module github.com/spf13/viper to v1.18.0
([#1060](#1060))
([9dfa689](9dfa689))


### 🧹 Chore

* refactoring component structure
([#1044](#1044))
([0c7f78a](0c7f78a))
* remove deprecated flags
([#1075](#1075))
([49f6fe5](49f6fe5))
</details>

<details><summary>core: 0.7.3</summary>

##
[0.7.3](core/v0.7.2...core/v0.7.3)
(2023-12-22)


### 🐛 Bug Fixes

* **deps:** update golang.org/x/exp digest to 6522937
([#1032](#1032))
([78b23d2](78b23d2))
* **deps:** update module connectrpc.com/connect to v1.13.0
([#1070](#1070))
([63f86ea](63f86ea))
* **deps:** update module github.com/diegoholiveira/jsonlogic/v3 to
v3.4.0 ([#1068](#1068))
([5c5d5ab](5c5d5ab))
* **deps:** update module github.com/open-feature/open-feature-operator
to v0.5.2 ([#1059](#1059))
([cefea3e](cefea3e))
* **deps:** update module google.golang.org/grpc to v1.60.0
([#1074](#1074))
([bf3e9d8](bf3e9d8))
* **deps:** update module google.golang.org/grpc to v1.60.1
([#1092](#1092))
([5bf1368](5bf1368))
* make sure sync builder is initialized to avoid nil pointer access
([#1076](#1076))
([ebcd616](ebcd616))


### ✨ New Features

* support new flagd.evaluation and flagd.sync schemas
([#1083](#1083))
([e9728aa](e9728aa))


### 🧹 Chore

* refactoring component structure
([#1044](#1044))
([0c7f78a](0c7f78a))
* renaming of evaluation components
([#1064](#1064))
([d39f31d](d39f31d))
* use client-go library for retrieving FeatureFlag CRs
([#1077](#1077))
([c86dff0](c86dff0))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants