[BUG] There is no "value" key in the evaluation response

[zeezdev]

Observed behavior

When a request to a new endpoint flagd.evaluation.v1.Service/ResolveBoolean (#1083) for a boolean flag evaluates to a negative variant, then the response is missing the value key:

{"reason":"TARGETING_MATCH", "variant":"off", "metadata":{}}

Expected Behavior

The evaluation response contains value key for both negative and positive variants:

{"value":false, "reason":"TARGETING_MATCH", "variant":"off", "metadata":{}}

{"value":true, "reason":"TARGETING_MATCH", "variant":"on", "metadata":{}}

Steps to reproduce

The flags definition (test.json):

{
  "flags": {
    "EXPERIMENT__CREATE": {
      "variants": {
        "on": true,
        "off": false
      },
      "state": "ENABLED",
      "defaultVariant": "off",
      "targeting": {
        "if": [
          {
            "==": [
              false,
              {
                "var": [
                  "user.is_superuser"
                ]
              }
            ]
          },
          "on",
          "off"
        ]
      }
    }
  }
}

Up flagd (v0.8.0):

docker run \
  --rm -it \
  --name flagd \
  -p 8013:8013 \
  -v $(pwd):/etc/flagd/ \
  ghcr.io/open-feature/flagd:v0.8.0 \
  start --uri file:/etc/flagd/test.json --debug

Request for a new endpoint (flagd.evaluation.v1.Service/ResolveBoolean) with a context for which the variant off is expected:

curl -X POST 'http://localhost:8013/flagd.evaluation.v1.Service/ResolveBoolean' \
--header 'Content-Type: application/json' \
--data '
{
	"flagKey": "EXPERIMENT__CREATE",
	"context": {
		"user": {
			"is_superuser": true
		}
	}
}'

The response does not contain value attribute:

{"reason":"TARGETING_MATCH", "variant":"off", "metadata":{}}

Request for a new endpoint (flagd.evaluation.v1.Service/ResolveBoolean) with a context for which the variant on is expected:

curl -X POST 'http://localhost:8013/flagd.evaluation.v1.Service/ResolveBoolean' \
--header 'Content-Type: application/json' \
--data '
{
	"flagKey": "EXPERIMENT__CREATE",
	"context": {
		"user": {
			"is_superuser": false
		}
	}
}'

The value attribute is present in the response:

{"value":true, "reason":"TARGETING_MATCH", "variant":"on", "metadata":{}}

When a request is made to the old endpoint by both contexts (off & on variants are expected), the response contains the value attribute:

curl -X POST 'http://localhost:8013/schema.v1.Service/ResolveBoolean' \
--header 'Content-Type: application/json' \
--data '
{
	"flagKey": "EXPERIMENT__CREATE",
	"context": {
		"user": {
			"is_superuser": false
		}
	}
}'

{"value":true, "reason":"TARGETING_MATCH", "variant":"on", "metadata":{}}

curl -X POST 'http://localhost:8013/schema.v1.Service/ResolveBoolean' \
--header 'Content-Type: application/json' \
--data '
{
	"flagKey": "EXPERIMENT__CREATE",
	"context": {
		"user": {
			"is_superuser": true
		}
	}
}'

{"value":false, "reason":"TARGETING_MATCH", "variant":"off", "metadata":{}}

[beeme1mr]

Hey @zeezdev, thanks for reporting this. I'll work on a fix right await.

[beeme1mr]

Fixed in v0.8.1