Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] serve both old and new protos #1029

Closed
toddbaert opened this issue Nov 24, 2023 · 1 comment · Fixed by #1083
Closed

[FEATURE] serve both old and new protos #1029

toddbaert opened this issue Nov 24, 2023 · 1 comment · Fixed by #1083
Assignees
@bacherfl
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

toddbaert commented Nov 24, 2023 •
edited
Loading

Requirements

With this PR we added better-named protos and endpoints. We should serve both of these for a while before removing the old ones in 1.0. See all the protos here: https://buf.build/open-feature/flagd

@bacherfl did a POC here: bacherfl#1

Note this should be done for both the flagd-proxy (sync.proto) and flagd itself (evaluation.proto).

See reasoning for new naming here: #948

cc @Kavindu-Dodan @bacherfl
@toddbaert toddbaert added enhancement New feature or request Needs Triage This issue needs to be investigated by a maintainer and removed Needs Triage This issue needs to be investigated by a maintainer labels Nov 24, 2023
@toddbaert toddbaert mentioned this issue Nov 28, 2023
Closed
@beeme1mr beeme1mr added the help wanted Extra attention is needed label Nov 28, 2023
@bacherfl
Copy link
Contributor

bacherfl commented Dec 13, 2023 •
edited
Loading

@toddbaert Having done the PoC I would gladly implement this :)

@bacherfl bacherfl mentioned this issue Dec 15, 2023
Merged
toddbaert added a commit that referenced this issue Dec 21, 2023
@bacherfl @toddbaert
feat: support new flagd.evaluation and flagd.sync schemas (#1083)
e9728aa 
Closes #1029 

This PR introduces support for the newly introduced evaluation and sync
schemas.

Supporting both the old and new schemas involves some duplication, but I
tried to keep it as minimal as possible. I'm of course open for
suggestions for any ideas on how to make this simpler :)

See reasoning for new naming
[here](#948).

---------

Signed-off-by: Florian Bacher <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bacherfl bacherfl

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support new flagd.evaluation and flagd.sync schemas bacherfl/flagd
3 participants
@beeme1mr @bacherfl @toddbaert