Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding Async Lifetime method to fix flaky unit tests #333

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

askpt
Copy link
Member

@askpt askpt commented Dec 18, 2024

This PR

  • Changes the way we currently reset the Api between unit tests. This approach should be safer since it calls the official Shutdown, and when we call the API again, all the resources are reset.

Notes

Check for more details: https://xunit.net/docs/shared-context#:~:text=For%20context%20cleanup%2C%20add%20the%20IDisposable%20interface%20to,call%20IAsyncDisposable%20%28it%20is%20planned%20for%20xUnit%20v3%29.

Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
@askpt askpt requested a review from a team as a code owner December 18, 2024 15:42
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.30%. Comparing base (6c4cd02) to head (bfd7340).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
- Coverage   85.54%   85.30%   -0.25%     
==========================================
  Files          36       36              
  Lines        1474     1477       +3     
  Branches      150      150              
==========================================
- Hits         1261     1260       -1     
- Misses        183      187       +4     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@toddbaert toddbaert merged commit e14ab39 into main Dec 19, 2024
14 of 15 checks passed
@askpt askpt deleted the askpt/fix-flaky-tests branch December 19, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants