Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update namespace from OpenFeature -> OpenFeature.SDK #23

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Update namespace from OpenFeature -> OpenFeature.SDK #23

merged 1 commit into from
Jul 18, 2022

Conversation

benjiro
Copy link
Member

@benjiro benjiro commented Jul 17, 2022

It is recommended not to share a namespace and class name to avoid import issues and code like OpenFeature.OpenFeature.Instance.*

Add test case for FeatureClient constructor that tests null provider

@benjiro benjiro requested a review from toddbaert July 17, 2022 12:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2022 •
edited
Loading

Codecov Report

Merging #23 (4c59ff0) into main (4446810) will increase coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   99.32%   99.66%   +0.33%     
==========================================
  Files          15       15              
  Lines         297      297              
  Branches       22       22              
==========================================
+ Hits          295      296       +1     
+ Partials        2        1       -1
Impacted Files Coverage Δ
src/OpenFeature/Constant/Reason.cs 100.00% <ø> (ø)
src/OpenFeature/Error/FeatureProviderException.cs 100.00% <ø> (ø)
src/OpenFeature/Extension/EnumExtensions.cs 100.00% <ø> (ø)
...enFeature/Extension/ResolutionDetailsExtensions.cs 100.00% <ø> (ø)
src/OpenFeature/Hook.cs 100.00% <ø> (ø)
src/OpenFeature/Model/ClientMetadata.cs 100.00% <ø> (ø)
src/OpenFeature/Model/EvaluationContext.cs 100.00% <ø> (ø)
src/OpenFeature/Model/FlagEvaluationOptions.cs 100.00% <ø> (ø)
src/OpenFeature/Model/FlagEvalusationDetails.cs 100.00% <ø> (ø)
src/OpenFeature/Model/HookContext.cs 100.00% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4446810...4c59ff0. Read the comment docs.

@benjiro benjiro force-pushed the chore/update-namespace branch from 5725c07 to 73f2655 Compare July 17, 2022 12:02
@benjiro
Update namespace from OpenFeature -> OpenFeature.SDK
4c59ff0 
It recommended not to share a namespace and class name to avoid import issues, and code like OpenFeature.OpenFeature.Instace.*

Signed-off-by: Benjamin Evenson <[email protected]>
@benjiro benjiro force-pushed the chore/update-namespace branch from 73f2655 to 4c59ff0 Compare July 18, 2022 11:09
@benjiro benjiro changed the title Update namespace from OpenFeature -> OpenFeatureSDK Update namespace from OpenFeature -> OpenFeature.SDK Jul 18, 2022
beeme1mr
beeme1mr approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks making the change.

@benjiro benjiro merged commit 424d48a into main Jul 18, 2022
@benjiro benjiro mentioned this pull request Aug 5, 2022
Merged
@benjiro benjiro deleted the chore/update-namespace branch August 14, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@toddbaert toddbaert Awaiting requested review from toddbaert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjiro @codecov-commenter @beeme1mr