Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "cannot bind packed field" on Ubuntu 20.04 #102

Conversation

luator
Copy link
Member

@luator luator commented Oct 18, 2021

Description

While the old version is building on Ubuntu 18.04, newer versions of gcc
do not allow the assignment to reference here.

Note that this PR goes to mnaveau/communication_benchmark as on master this has already been fixed.

How I Tested

Build using an Ubuntu 20.04 image.

I fulfilled the following requirements

  • All new code is formatted according to our style guide (for C++ run clang-format, for Python, run flake8 and fix all warnings).
  • All new functions/classes are documented and existing documentation is updated according to changes.
  • No commented code from testing/debugging is kept (unless there is a good reason to keep it).

While the old version is building on Ubuntu 18.04, newer versions of gcc
do not allow the assignment to reference here.
@MaximilienNaveau MaximilienNaveau merged commit e7129ed into mnaveau/communication_benchmark Oct 27, 2021
@luator luator deleted the fwidmaier/fix_for_ubuntu_20.04 branch October 27, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants