Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed DIS6 Variable Datum and Chunk classes #20

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Fixed DIS6 Variable Datum and Chunk classes #20

merged 1 commit into from
Jun 12, 2023

Conversation

crhowell3
Copy link

@leif81 if possible, review these changes and cut an NPM release as soon as you can. Thanks!

@leif81 leif81 linked an issue Jun 12, 2023 that may be closed by this pull request
DIS 6 Variable Datum and Chunk are broken #19
Closed
@leif81
Copy link
Member

leif81 commented Jun 12, 2023

Thanks @crhowell3 !
I'm good with this change.
The DIS 6 VariableDatum class will now have the same fix that was applied on the DIS7 implementation of VariableDatum (ref 202e085)

@leif81 leif81 merged commit e6e8d83 into open-dis:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DIS 6 Variable Datum and Chunk are broken
2 participants
@crhowell3 @leif81