Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? Jupyter-lab broken with pinned Jinja2 #87

Closed
matthew-brett opened this issue Feb 19, 2022 · 3 comments
Closed

New release? Jupyter-lab broken with pinned Jinja2 #87

matthew-brett opened this issue Feb 19, 2022 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@matthew-brett
Copy link
Contributor

Would you consider making a new release?

I just pip-installed Dicom_parser, and JupyterLab, and this gave me a broken JupyterLab:

$ mkvirtualenv test
$ pip install jupyterlab
$ pip install dicom_parser

This ends with output:

Installing collected packages: numpy, pydicom, pandas, nibabel, jinja2, dicom-parser
  Attempting uninstall: jinja2
    Found existing installation: Jinja2 3.0.3
    Uninstalling Jinja2-3.0.3:
      Successfully uninstalled Jinja2-3.0.3
Successfully installed dicom-parser-1.1.1 jinja2-2.11.3 nibabel-3.2.2 numpy-1.22.2 pandas-1.4.1 pydicom-2.1.2

Notice the downgrade of Jinja. Next:

$ jupyter-lab

Gives:

[snip]
ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/Volumes/zorg/mb312/.virtualenvs/test/lib/python3.8/site-packages/markupsafe/__init__.py)

Web search gives this thread, which suggests:

pip install -U jinja2

Sure enough, this fixes it.

Repeating these steps, but installing from latest Master locally, does not downgrade Jinja2, and does not cause this error.

Maybe a new release would prevent this error?

@ZviBaratz
Copy link
Collaborator

Certainly. Do you think I should wait until we merge the existing PR or just go for it?

@matthew-brett
Copy link
Contributor Author

matthew-brett commented Feb 19, 2022 via email

@ZviBaratz
Copy link
Collaborator

Published v1.2.0.

@ZviBaratz ZviBaratz added the bug Something isn't working label Feb 20, 2022
@ZviBaratz ZviBaratz added this to the v1.2.0 milestone Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants