-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass DataStore Upsert Original pSQL Error Messages #188
Conversation
- Include the original psql error message and code in the upsert errors.
- Added change log file.
- Continued FK maps in datastore_info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of maintaining this patch on our fork can we parse the FK errors here and return them in a way that would be useful for all API users? That kind of a change could go upstream eventually
@wardi like the REGEX parsing that I have done in Recombinant? Move it into the ckanext-datastore postgres.py ?? |
- Finalized foreign constraint info for datastore_info.
@wardi I threw the Foreign Key info for datastore_info into this one too if your able to review that here as well?? |
- Query for constraint usage.
- Parse psql errors for foreign constraints. - Use psql literal strings for ds info fks.
@wardi okay! should be handling the foreign constraint errors in here now. Will parse them and give an error message along with a dict of the parsed values (ref keys, ref values, ref table name). |
- Return list of strings.
Co-authored-by: Ian Ward <[email protected]>
- Fake gettext for babel extractions.
- Added comments for the parial string formatter.
feat(logic): ds upsert info;
This will allow Recombinant to parse the FK constraint error messages, without showing the pSQL error to the user still.