MCKIN-12768 Feedback icons changed to button for averall assessment c…

…ase (#257) Improve accessibility of feedback icon by making it focus-able and adding aria labels.
open-craft · Jan 24, 2020 · 3f8a726 · 3f8a726
1 parent c80aa10
commit 3f8a726
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/problem_builder/public/css/questionnaire.css b/problem_builder/public/css/questionnaire.css
@@ -154,3 +154,10 @@
     right: auto;
     left: 3px;
 }
+
+.assessment-question-block .submit button.step-overall-checkmark {
+    border: 0;
+    padding: 0;
+    background: none;
+    box-shadow: none !important;
+}
diff --git a/problem_builder/templates/html/mentoring_with_steps.html b/problem_builder/templates/html/mentoring_with_steps.html
@@ -14,9 +14,9 @@ <h3>{{ title }}</h3>
     {% endfor %}
 
     <div class="submit">
-      <span class="step-overall-checkmark fa icon-2x fa-fw" aria-label=""
+      <button class="step-overall-checkmark fa icon-2x fa-fw" aria-label=""
           data-label_correct="{% trans "Correct" %}" data-label_incorrect="{% trans "Incorrect" %}"
-          data-label_partial="{% trans "Partially correct" %}"></span>
+          data-label_partial="{% trans "Partially correct" %}"></button>
       <input type="button" class="input-main" value="{% trans "Submit" %}" disabled="disabled" />
       <input type="button" class="input-next" value="{% trans "Next Step" %}" disabled="disabled" />
       <input type="button" class="input-review" value="{% trans "Review grade" %}" disabled="disabled" />

diff --git a/setup.py b/setup.py
@@ -28,7 +28,7 @@
 
 # Constants #########################################################
 
-VERSION = '3.4.8'
+VERSION = '3.4.9'
 
 # Functions #########################################################