feat: Deprecates CONTENT_OBJECT_TAGS_CHANGED in favor of CONTENT_OBJECT_ASSOCIATIONS_CHANGED [FC-0062] #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomegranited
force-pushed
the
jill/content-object-associations
branch
from
6e0b50b to
6c30e2a
Compare
|
@bradenmacdonald Do we need to deprecate the old event before changing it here? It's unlikely that anyone is using |
|
@pomegranited They might be in the future too (between now and whenever they upgrade to Sumac), so I think we should deprecate it. We could emit both events for a while; it doesn't really cost us anything to emit |
and ContentObjectChangedData, which has a field for indicating what has changed.
pomegranited
force-pushed
the
jill/content-object-associations
branch
from
6c30e2a to
a4aba00
Compare
pomegranited
changed the title
pomegranited
force-pushed
the
jill/content-object-associations
branch
from
a4aba00 to
9fbf1e4
Compare
rpenido
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
LGTM 👍
Thank you for your work, @pomegranited!
I have nothing to note here.
- I tested this using the instructions from Store content object collections in search index [FC-0062] edx-platform#680 (review)
- I read through the code
-
I checked for accessibility issues - Includes documentation
pomegranited
merged commit ef00ede
into
yusuf-musleh/content-library-collections-signals
9 checks passed
pomegranited
added a commit
that referenced
this pull request
Sep 6, 2024
…CT_ASSOCIATIONS_CHANGED #66 * feat: adds event CONTENT_OBJECT_ASSOCIATOONS_CHANGED and ContentObjectChangedData, which has a field for indicating what has changed. * chore: updates changelog
navinkarkera
added a commit
to openedx/openedx-events
that referenced
this pull request
Sep 6, 2024
* feat: Add Content Library Collections signals * fix: use collection_key (str) instead of id (int) * docs: update CHANGELOG * feat: Deprecates CONTENT_OBJECT_TAGS_CHANGED in favor of CONTENT_OBJECT_ASSOCIATIONS_CHANGED open-craft#66 * feat: adds event CONTENT_OBJECT_ASSOCIATOONS_CHANGED and ContentObjectChangedData, which has a field for indicating what has changed. * chore: updates changelog * fix: fix conflicts in CHANGELOG * fix: use content_library subdomain for new events * fix: add library collection events to changelog --------- Co-authored-by: Jillian Vogel <[email protected]> Co-authored-by: Navin Karkera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deprecates the
CONTENT_OBJECT_TAGS_CHANGEDevent in favor of the newCONTENT_OBJECT_ASSOCIATIONS_CHANGEDevent.This new name and data structure better reflect the additional use of this event, which is triggered when a ContentObject's tags or Collections change.
ISSUE: openedx/modular-learning#230
Private-ref: FAL-3787
Dependencies: openedx#386
OK to merge this change into that PR so we can get them CC reviewed together.
Merge deadline: ASAP
Installation instructions: List any non-trivial installation instructions.
Testing instructions:
Unit tests should be sufficient to verify this change, but see open-craft:edx-platform#680 for detailed testing instructions.
Merge checklist:
Post merge:
finished.
Author concerns:
CONTENT_OBJECT_TAGS_CHANGEDis removed after Sumac.