fix: Fixes the saving pop-up to appear

Moves the array updation statement and introduces two ways of updating the grading statement. Signed-off-by: Farhaan Bukhsh <[email protected]>
open-craft · Oct 22, 2024 · e7c5b7f · e7c5b7f
1 parent 3b56fab
commit e7c5b7f
Showing 1 changed file with 31 additions and 27 deletions.
diff --git a/src/grading-settings/grading-scale/GradingScale.jsx b/src/grading-settings/grading-scale/GradingScale.jsx
@@ -55,40 +55,44 @@ const GradingScale = ({
   }, [gradingSegments, letters]);
 
   const addNewGradingSegment = () => {
-    setGradingSegments(prevSegments => {
+    setGradingSegments((prevSegments) => {
+      let updatedGradingSegment = [];
       if (prevSegments.length >= 5) {
         const segSize = MAXIMUM_SCALE_LENGTH / (prevSegments.length + 1);
-        return Array.from({ length: prevSegments.length + 1 }).map((_, i) => (
-          {
-            current: 100 - i * segSize,
-            previous: 100 - (i + 1) * segSize,
-          }
-        ));
-      }
-      const firstSegment = prevSegments[prevSegments.length - 1];
-      const secondSegment = prevSegments[prevSegments.length - 2];
-      const newCurrentValue = Math.ceil((secondSegment.current - secondSegment.previous) / 2);
-
-      const newSegment = {
-        current: (firstSegment.current + newCurrentValue),
-        previous: firstSegment.current,
-      };
+        updatedGradingSegment = Array.from({
+          length: prevSegments.length + 1,
+        }).map((_, i) => ({
+          current: 100 - i * segSize,
+          previous: 100 - (i + 1) * segSize,
+        }));
+      } else {
+        const firstSegment = prevSegments[prevSegments.length - 1];
+        const secondSegment = prevSegments[prevSegments.length - 2];
+        const newCurrentValue = Math.ceil(
+          (secondSegment.current - secondSegment.previous) / 2,
+        );
+
+        const newSegment = {
+          current: firstSegment.current + newCurrentValue,
+          previous: firstSegment.current,
+        };
 
-      const updatedSecondSegment = {
-        ...secondSegment,
-        previous: (firstSegment.current + newCurrentValue),
-      };
+        const updatedSecondSegment = {
+          ...secondSegment,
+          previous: firstSegment.current + newCurrentValue,
+        };
+        updatedGradingSegment = [
+          ...prevSegments.slice(0, prevSegments.length - 2),
+          updatedSecondSegment,
+          newSegment,
+          firstSegment,
+        ];
+      }
 
       showSavePrompt(true);
       setShowSuccessAlert(false);
       setOverrideInternetConnectionAlert(false);
-
-      return [
-        ...prevSegments.slice(0, prevSegments.length - 2),
-        updatedSecondSegment,
-        newSegment,
-        firstSegment,
-      ];
+      return updatedGradingSegment;
     });
 
     const nextIndex = (letters.length % defaultGradeDesignations.length);