fix(redwood): ensure TagCountFactory is bundled in production
#727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agrendalath
changed the title
TagCountFactory is bundled in productionTagCountFactory is bundled in production
Remove the `static:webpack` directive and use `add_webpack_js_to_fragment` to properly include TagCountFactory in production. The previous solution did not correctly bundle this factory, causing the `ReferenceError: TagCountFactory is not defined` JS error in the Studio preview.
Agrendalath
force-pushed
the
agrendalath/fix-studio-preview-redwood
branch
from
57ac262 to
d4e574f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
static:webpackdirective and useadd_webpack_js_to_fragmentto properly include TagCountFactory in production. The previous solution (openedx#34059) did not correctly bundle this factory, causing theReferenceError: TagCountFactory is not definedJS error in the Studio preview.Testing instructions
tutor dev exec cms npm run webpack.ReferenceError: TagCountFactory is not definederror in the console logs.Private-ref: TBD