Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BB-4047][Backport] fix: fix typo that prevented video completion working as intended #348

Merged
merged 1 commit into from
Apr 30, 2021
Merged

[BB-4047][Backport] fix: fix typo that prevented video completion working as intended #348

merged 1 commit into from
Apr 30, 2021

Conversation

Agrendalath
Copy link
Member

This backports the fix from edx/edx-platform#27230.

Testing instructions

  1. Check that the diff is matching the original commit: 5169d70.

@mikix @Agrendalath
fix: fix typo that prevented video completion working as intended
361fc7d 
Neither of these settings were being correctly set:
* COMPLETION_BY_VIEWING_DELAY_MS
* COMPLETION_VIDEO_COMPLETE_PERCENTAGE

AA-743

(cherry picked from commit 5169d70)
@Agrendalath Agrendalath requested a review from janimo April 30, 2021 15:25
@Agrendalath Agrendalath self-assigned this Apr 30, 2021
janimo
janimo approved these changes Apr 30, 2021
View reviewed changes
Copy link

@janimo janimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: (describe what you tested)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@Agrendalath Agrendalath merged commit b6b08de into opencraft-release/koa.3 Apr 30, 2021
@Agrendalath Agrendalath deleted the agrendalath/bb-4047_backport_upstream_fix branch April 30, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janimo janimo janimo approved these changes

Assignees

@Agrendalath Agrendalath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Agrendalath @janimo @mikix