-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): also call make generate to update files #992
chore(release): also call make generate to update files #992
Conversation
072fe14
to
50a9912
Compare
50a9912
to
005240d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - not sure if it's necessary to also adjust the commit message?
Hmm it says update version "file" so thats technically no longer correct, im adjusting |
005240d
to
eb465c4
Compare
eb465c4
to
4d1f1ca
Compare
17f787a
to
20379de
Compare
20379de
to
4a85b82
Compare
I don't like this idea. All PRs should generate content. This potentially will leave a dirty branch or a dirty main that people don't expect. It could potentially could leave a branch with data that the developers are unaware of and had not committed or created. I know that it's only generated data, nevertheless it's unexpected code that we potentially are unaware off. I don't like just plain committing generated code into the release especially if we had guards against merging prs that have ungenerated modifications in them. |
For now, this is fine though. I realise that there are no other options in this case since the current automation will use the version as a stage point. We'll figure something out. :D |
Ill create a follow up because you still have a point. We need to make sure this generation doesnt fall on our face. |
This allows us to also generate the README.md files automatically so that they contain correct references
What this PR does / why we need it
Which issue(s) this PR fixes
#990