Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): also call make generate to update files #992

Conversation

jakobmoellerdev
Copy link
Contributor

This allows us to also generate the README.md files automatically so that they contain correct references

What this PR does / why we need it

Which issue(s) this PR fixes

#990

@github-actions github-actions bot added the chore label Oct 21, 2024
@jakobmoellerdev jakobmoellerdev force-pushed the chore/auto-make-generate-on-release branch from 072fe14 to 50a9912 Compare October 21, 2024 11:32
@hilmarf hilmarf added this to the 2024-Q4 milestone Oct 21, 2024
@jakobmoellerdev jakobmoellerdev force-pushed the chore/auto-make-generate-on-release branch from 50a9912 to 005240d Compare October 21, 2024 11:36
hilmarf
hilmarf previously approved these changes Oct 21, 2024
Copy link
Member

@hilmarf hilmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - not sure if it's necessary to also adjust the commit message?

@jakobmoellerdev
Copy link
Contributor Author

Hmm it says update version "file" so thats technically no longer correct, im adjusting

hilmarf
hilmarf previously approved these changes Oct 21, 2024
@jakobmoellerdev jakobmoellerdev force-pushed the chore/auto-make-generate-on-release branch from eb465c4 to 4d1f1ca Compare October 22, 2024 13:21
@jakobmoellerdev jakobmoellerdev force-pushed the chore/auto-make-generate-on-release branch 2 times, most recently from 17f787a to 20379de Compare October 22, 2024 13:23
@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review October 22, 2024 13:23
@jakobmoellerdev jakobmoellerdev requested a review from a team as a code owner October 22, 2024 13:23
@jakobmoellerdev jakobmoellerdev force-pushed the chore/auto-make-generate-on-release branch from 20379de to 4a85b82 Compare October 22, 2024 19:27
@jakobmoellerdev jakobmoellerdev enabled auto-merge (squash) October 24, 2024 07:02
@Skarlso
Copy link
Contributor

Skarlso commented Oct 24, 2024

I don't like this idea. All PRs should generate content. This potentially will leave a dirty branch or a dirty main that people don't expect. It could potentially could leave a branch with data that the developers are unaware of and had not committed or created.

I know that it's only generated data, nevertheless it's unexpected code that we potentially are unaware off. I don't like just plain committing generated code into the release especially if we had guards against merging prs that have ungenerated modifications in them.

@Skarlso
Copy link
Contributor

Skarlso commented Oct 24, 2024

For now, this is fine though. I realise that there are no other options in this case since the current automation will use the version as a stage point.

We'll figure something out. :D

@jakobmoellerdev jakobmoellerdev merged commit ed93e9a into open-component-model:main Oct 24, 2024
15 checks passed
@jakobmoellerdev
Copy link
Contributor Author

Ill create a follow up because you still have a point. We need to make sure this generation doesnt fall on our face.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

3 participants