Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce update state on CV implementation API #976

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

mandelsoft
Copy link
Contributor

@mandelsoft mandelsoft commented Oct 17, 2024

What this PR does / why we need it

Extend the CV implementation API to provide information, whether an Update of the descriptor has been done.
This information is then used to trigger the pubsub handler.
If no update has been done, the query of the repository's pubsub info is omitted.

Which issue(s) this PR fixes

@fabianburth
Copy link
Contributor

are there tests for this behaviour?

@frewilhelm
Copy link
Contributor

Will this fix #872?

@hilmarf hilmarf added this to the 2024-Q4 milestone Oct 21, 2024
@hilmarf hilmarf requested a review from fabianburth October 21, 2024 07:40
@jakobmoellerdev
Copy link
Contributor

just needs a rebase and a rereview

Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hilmarf hilmarf dismissed fabianburth’s stale review October 21, 2024 11:36

changes are done

@hilmarf hilmarf enabled auto-merge (squash) October 21, 2024 11:36
@jakobmoellerdev
Copy link
Contributor

Will this fix #872?

no @frewilhelm

@hilmarf hilmarf merged commit 4ad368d into open-component-model:main Oct 21, 2024
15 checks passed
@mandelsoft mandelsoft deleted the pubsub branch October 21, 2024 12:02
Skarlso pushed a commit that referenced this pull request Oct 22, 2024
<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it

Extend the CV implementation API to provide information, whether an
Update of the descriptor has been done.
This information is then used to trigger the pubsub handler.
If no update has been done, the query of the repository's pubsub info is
omitted.

#### Which issue(s) this PR fixes
<!--
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

5 participants