Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare dynamic format recognition for object set serialization filesystem formats #97

Merged
merged 6 commits into from
Oct 12, 2022

Conversation

mandelsoft
Copy link
Contributor

Switch from a static set of data for configure the filesystem format
to a potentially dynamic format specification supporting format
discovery based on the actual state of the filesystem.

The static structure describing fixed values for various features
is replaced by an interface with an additional discover method.

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@In-Ko
Copy link
Member

In-Ko commented Sep 5, 2022

This PR is to prepare being conform to https://github.com/opencontainers/image-spec/blob/main/image-layout.md.

@gardener-robot
Copy link
Contributor

@mandelsoft You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added size/xl and removed size/m Medium labels Sep 7, 2022
@mandelsoft
Copy link
Contributor Author

Unfortunately I had to provide support now for the extended accessio options to be able to pass additional options not used by the accessio package. This was required to give users of the accessio lib the chance to provide extended options. For the artfefactset this if the structure format option.

This required some changed in the option and error handling for the options, which must be adjusted at various places.

@mandelsoft mandelsoft changed the title prepare dynamic format recognition for object set serialization filesystem formats WIP: prepare dynamic format recognition for object set serialization filesystem formats Sep 9, 2022
@mandelsoft mandelsoft changed the title WIP: prepare dynamic format recognition for object set serialization filesystem formats prepare dynamic format recognition for object set serialization filesystem formats Sep 26, 2022
@mandelsoft mandelsoft marked this pull request as ready for review September 26, 2022 08:14
@mandelsoft mandelsoft force-pushed the mandelsoft/format branch 3 times, most recently from 1bbc404 to 6036ffc Compare October 5, 2022 12:32
jensh007
jensh007 previously approved these changes Oct 5, 2022
yitsushi
yitsushi previously approved these changes Oct 10, 2022
@mandelsoft mandelsoft dismissed stale reviews from yitsushi and jensh007 via 18fbe17 October 12, 2022 17:01
@mandelsoft
Copy link
Contributor Author

mandelsoft commented Oct 12, 2022

Just rebased to be mergeable

@mandelsoft mandelsoft requested a review from jensh007 October 12, 2022 17:02
…ystem formats

Switch from a static set of data for configure the filesystem format
to a potentially dynamic format specification supporting format
discovery based on the actual state of the filesystem.

The static structure describing fixed values for various features
is replaced by an interface with an additional discover method.
@mandelsoft
Copy link
Contributor Author

This Update by rebase button separately pushes all the commits of PR.

@mandelsoft mandelsoft merged commit 9f733c1 into main Oct 12, 2022
@mandelsoft mandelsoft deleted the mandelsoft/format branch October 12, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants