Custom Unmarshaler for Consumer Identity #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding this custom unmarshaler to the consumer identity allows a yaml specification containing a data type other string, e.g. a hostpath spec with a port. Previously, it would error if the user specified `port: 5000` and instead, the user had to specify `port: "5000"`.
frewilhelm
previously approved these changes
Sep 16, 2024
ikhandamirov
previously approved these changes
Sep 16, 2024
mandelsoft
requested changes
Sep 16, 2024
fabianburth
dismissed stale reviews from ikhandamirov and frewilhelm
via
e774b4c
mandelsoft
approved these changes
Sep 16, 2024
fabianburth
added a commit
that referenced
this pull request
Nov 7, 2024
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Fix empty identity value regression. The regression was introduced after this [PR](#927) adding a custom unmarshaler for consumer identities which allows to specify values other than string (e.g. port: 5000), even though consumer identity is a map[string]string. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR adds a custom unmarshaler to the consumer identity type.
Adding this custom unmarshaler to the consumer identity allows a yaml specification containing a data type other string, e.g. a hostpath spec with a port. Previously, it would error if the user specified
port: 5000and instead, the user had to specifyport: "5000".Which issue(s) this PR fixes