-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix npm input #900
fix npm input #900
Conversation
Basically, there is a third application for the BlobAccess, the convenience code bundling the access with the resource/source data to add resources and sources to a CV. This can always be done by specifying the meta data together with a blob access when adding the artifact. If we decide to kept it, such compound implementations have to provided for the NPM BlobAccess, also. |
What this PR does / why we need it
fix problems with npm input handling:
Accesses for external registries are always handled the same way:
BlobAccess
implementation for that kind of registry with all the options required (for example credentials, caches,...)BlobAccess
is then used for the input and access method implementations.Before, there was only the access method implementation. This PR generalizes this implementation and moves it to
a new
BlobAccess
implementation. The access method implementation has be changed to use thisBlobAccess
type.The input implementation has been changed to use this implementation, also, by providing all the required options.
The implementations for maven and npm are similar, therefore the option handling for both blob access types
has been aligned.
Which issue(s) this PR fixes