Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npm input #900

Merged
merged 7 commits into from
Sep 3, 2024
Merged

fix npm input #900

merged 7 commits into from
Sep 3, 2024

Conversation

mandelsoft
Copy link
Contributor

@mandelsoft mandelsoft commented Aug 30, 2024

What this PR does / why we need it

fix problems with npm input handling:

  • add missing input registration
  • align cli options
  • fix typos
  • fix html formatting for maven
  • align input/access and blob access (see below)

Accesses for external registries are always handled the same way:

  • there is BlobAccessimplementation for that kind of registry with all the options required (for example credentials, caches,...)
  • this BlobAccess is then used for the input and access method implementations.

Before, there was only the access method implementation. This PR generalizes this implementation and moves it to
a new BlobAccess implementation. The access method implementation has be changed to use this BlobAccess type.
The input implementation has been changed to use this implementation, also, by providing all the required options.

The implementations for maven and npm are similar, therefore the option handling for both blob access types
has been aligned.

Which issue(s) this PR fixes

@mandelsoft mandelsoft marked this pull request as draft August 30, 2024 07:25
@mandelsoft
Copy link
Contributor Author

mandelsoft commented Aug 31, 2024

Basically, there is a third application for the BlobAccess, the convenience code bundling the access with the resource/source data to add resources and sources to a CV.

This can always be done by specifying the meta data together with a blob access when adding the artifact.
For some reason there were convenience operations requested bundlings these specification. This required to provide implementations for all combinations of BlobAccess types and resource/source meta data. Those implementations are in package elements. Technically this code is not required, we have to decide whether we want to keep it.

If we decide to kept it, such compound implementations have to provided for the NPM BlobAccess, also.

@mandelsoft mandelsoft marked this pull request as ready for review August 31, 2024 15:21
Skarlso
Skarlso previously approved these changes Sep 2, 2024
@hilmarf hilmarf enabled auto-merge (squash) September 3, 2024 08:23
@hilmarf hilmarf added this to the 2024-Q3 milestone Sep 3, 2024
@hilmarf hilmarf merged commit 55da331 into open-component-model:main Sep 3, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

3 participants