Fixes for upcoming issues during demo preparation + improvements discovered during execution of the demo flow #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandelsoft
force-pushed
the
mandelsoft/docker
branch
from
711a1e7 to
23d31e5
Compare
mandelsoft
force-pushed
the
mandelsoft/docker
branch
from
757185c to
3c83ef8
Compare
jensh007
approved these changes
Aug 31, 2022
jensh007
previously approved these changes
Aug 31, 2022
jschicktanz
suggested changes
Aug 31, 2022
jschicktanz
previously approved these changes
Aug 31, 2022
gardener-robot
added
size/m
jensh007
force-pushed
the
mandelsoft/docker
branch
from
ea49e27 to
1cd34de
Compare
mandelsoft
force-pushed
the
mandelsoft/docker
branch
from
1cd34de to
8a64fad
Compare
|
Do I see it correctly that this has some unrelated changes to the actual fix of he dockerdaemon connection? |
|
@mandelsoft How does this commit relate to the docker bug fix? If it's not related, would you mind please not polluting this PR further with unrelated changes? :) Thanks. :) |
mandelsoft
changed the title
mandelsoft
force-pushed
the
mandelsoft/docker
branch
from
7cd478d to
1cb0f6d
Compare
|
So, the demo is prepared, we will not add further content here, and it is ready for review. |
mandelsoft
force-pushed
the
mandelsoft/docker
branch
from
ff807d9 to
ed8ded5
Compare
|
rebased and linted, no content change besides reordering the imports. I would prefer to merge this one, before rebasing the localize PR, to avoid this additional rebase effort. |
yitsushi
approved these changes
Sep 7, 2022
Skarlso
approved these changes
Sep 7, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #74
Special notes for your reviewer:
Release note: