OCM localization support #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandelsoft
requested review from
Diaphteiros and
robertgraeff
and removed request for
a team
Skarlso
reviewed
Aug 28, 2022
For the future, please try to keep fixes out of feature prs for the following reason:
Thanks! |
|
I completely agree, here I urgently required this fix. And to be honest I forgot to create a separate commit for the fix. |
Merged
mandelsoft
force-pushed
the
localize
branch
2 times, most recently
from
5c00c3f to
30acb49
Compare
|
@robertgraeff, @Diaphteiros You have pull request review open invite, please check |
Skarlso
reviewed
Sep 2, 2022
Skarlso
reviewed
Sep 2, 2022
Skarlso
reviewed
Sep 2, 2022
Skarlso
reviewed
Sep 2, 2022
Skarlso
reviewed
Sep 2, 2022
Skarlso
reviewed
Sep 2, 2022
Skarlso
reviewed
Sep 2, 2022
Skarlso
reviewed
Sep 2, 2022
Skarlso
reviewed
Sep 2, 2022
Skarlso
reviewed
Sep 2, 2022
Skarlso
reviewed
Sep 2, 2022
Skarlso
reviewed
Sep 2, 2022
Skarlso
reviewed
Sep 2, 2022
Skarlso
reviewed
Sep 2, 2022
|
I'll rebase now |
Skarlso
previously approved these changes
Sep 6, 2022
mandelsoft
force-pushed
the
localize
branch
2 times, most recently
from
83a5bdd to
19ea492
Compare
Skarlso
previously approved these changes
Sep 6, 2022
yitsushi
previously approved these changes
Sep 7, 2022
Additionally I found a strange behaviour of the yaml path library. It cannot handle mixed yaml json. The resulting output when executing a modification is a completely corrupted yaml. Now, the susbtitution package wraps this lib by feeding it with pure json or yaml, only, dependening on the original input format.
|
rebased and linted |
Skarlso
approved these changes
Sep 7, 2022
yitsushi
approved these changes
Sep 8, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR provides some support for localization and configuration of filesystem snapshots
based on information provided by component versions and user configuration.
Additionally, it contains a fix for the Tar resource generation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: