-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM descriptor as CRD #69
Conversation
@Skarlso Thank you for your contribution. |
Hmm, hmm. I'm a bit perplexed as to the structure based on the v2, v3 schemas. The question here is whether to embed the Object or not. But if we embed the Object, all the values will have an apiVersion which is not something that will work nicely in Kubernetes. So, maybe we stay with an approximation instead of a full 1:1 mapping. |
89c733c
to
88ff539
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to put the CRD stuff into a some sub directory?
It is quite prominent, so far. And the structure does not really meet the actual project structure.
Basically, instead of using own types for the various elements the CRD should use the
already existing binding types. Is this possible?
Or alternatively, we need a transfer function, that provides a component descriptor (according to this library) from the K8S resource, and the opposite direction, putting a CD into an K8S resource.
This should be based on the internal structure (package compdesc), not the serialization versions. This would support a smooth usage together with the rest of the lib.
Yep, that's how most projects do it. If you have some kind of internal structure you usually do a transformation between that and the k8s representation.
This is the convention for any CRD in any project by the CRD generator codes. We can put it elsewhere of course, but that's not really intuitive, not to mention that some tooling like code-generators might not work appropriately. I suggest we follow the standards in this case as it's a well-trodden path. |
8b609bc
to
4e7ee00
Compare
This is now ready for review. It got a lot simpler as its reused internal, already existing definitions and types. 🎉 |
@In-Ko You have pull request review open invite, please check |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #35
Special notes for your reviewer:
Release note: