rework OCI push handling #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandelsoft
requested review from
Diaphteiros and
robertgraeff
and removed request for
a team
mandelsoft
force-pushed
the
mandelsoft/work
branch
from
36115dd to
ad4dd17
Compare
Skarlso
reviewed
Aug 26, 2022
| } | ||
| acc = localblob.New(blob.Digest().String(), hint, blob.MimeType(), acc) | ||
| } | ||
| return acc, nil | ||
| } | ||
|
|
||
| func wrap(err error, msg string, args ...interface{}) error { |
There was a problem hiding this comment.
So... yet another way for wrapping errors in this codebase? :D
There was a problem hiding this comment.
That is a local method used to encapsulate the multiple occurrences of an error wrapping with a common context handling for the local package. It is used to avoid the same coding again and again.
|
@robertgraeff, @Diaphteiros You have pull request review open invite, please check |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The actual version of the OCI push handling taken from the containerd library does not handle retries during a manifest push
correctly.
The API approach of providing a writer to the client, is not suitable for retries. The actual change migrates the push API from a eriter to a reader-factory approach, also used by the http client API.
Additionally various problems concerning the explode handling and the transfer CLI command are fixed.
Which issue(s) this PR fixes:
Fixes #61
Special notes for your reviewer:
Release note: