add --lookup option #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschicktanz
requested review from
achimweigel and
In-Ko
and removed request for
a team
jschicktanz
requested review from
mandelsoft
and removed request for
achimweigel
mandelsoft
requested changes
Sep 5, 2022
| return nil | ||
| } | ||
|
|
||
| func WithResolver(resolver ocm.ComponentVersionResolver) transferhandler.TransferOption { |
There was a problem hiding this comment.
The options functions so far do not is the With prefix.
Such functions are typically used to setup a builder, which we do not have here.
| }) | ||
| }) | ||
|
|
||
| env.OCMCommonTransport(componentBArchive, accessio.FormatDirectory, func() { |
There was a problem hiding this comment.
Is this really additive, if A and B are the same archive file?
There was a problem hiding this comment.
yes, i debugged into a test and it works.
also the other test is still running
| } | ||
|
|
||
| func (o *resolverOption) ApplyTransferOption(to transferhandler.TransferOptions) error { | ||
| to.(ResolverOption).SetResolver(o.resolver) |
There was a problem hiding this comment.
May be, we should for all those cases return an error if the actual option set does not accept this kind of config
|
@jschicktanz You need rebase this pull request with latest master branch. Please check. |
Skarlso
approved these changes
Sep 5, 2022
mandelsoft
approved these changes
Sep 6, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add
--lookupoption to various commands.as a prerequisite, added support for lookup option in transfer handler.
Which issue(s) this PR fixes:
Fixes #17
Special notes for your reviewer:
Release note: