-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded spec for the OCM model elements and their relations to each other #58
Conversation
dbd5986
to
891dab9
Compare
Most of this should imo be part of the spec itself (ocm-spec repository), and therefore needs to be integrated there, and not separated into some short documentation in the ocm repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Half-way through. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional review notes.
@mandelsoft don't know if you saw, but there are a few more remarks that have been hidden. :D |
@In-Ko I think after we finish collaborating on this PR we can merge it and THEN move the things out into the spec repo because this PR contains some minor code changes as well. Are you okay with that? |
I hope, I have got it all now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM!
@mandelsoft You need rebase this pull request with latest master branch. Please check. |
A transport tool, can use the bill of material to determine the set of | ||
artefacts that have to be transferred and use the access information to access | ||
the technical content of the artefacts in the source environment. They will then | ||
be copied into a repository landscape on the target side. In the target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be copied into a repository landscape on the target side. In the target | |
be copied into a repository on the target side. In the target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can really be a complete landscape. It is possible to define upload handlers, that upload localBlobs
of a dedicated type into any other repository. https://github.com/gardener/ocm/tree/main/pkg/contexts/ocm/blobhandler
19497db
to
b0adf9d
Compare
@Diaphteiros You have pull request review open invite, please check |
rebased to resolve conflicts |
What this PR does / why we need it:
This is work in progress.
I do not find this draft button on the github UI
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: