Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded spec for the OCM model elements and their relations to each other #58

Merged
merged 10 commits into from
Aug 24, 2022

Conversation

mandelsoft
Copy link
Contributor

@mandelsoft mandelsoft commented Aug 13, 2022

What this PR does / why we need it:

This is work in progress.
I do not find this draft button on the github UI

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@In-Ko
Copy link
Member

In-Ko commented Aug 15, 2022

Most of this should imo be part of the spec itself (ocm-spec repository), and therefore needs to be integrated there, and not separated into some short documentation in the ocm repo.

Copy link
Contributor

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Half-way through. :)

docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Show resolved Hide resolved
docs/names/repositorytypes.md Outdated Show resolved Hide resolved
docs/ocm/interoperability.md Outdated Show resolved Hide resolved
docs/ocm/interoperability.md Outdated Show resolved Hide resolved
docs/ocm/interoperability.md Show resolved Hide resolved
docs/ocm/interoperability.md Outdated Show resolved Hide resolved
docs/ocm/model.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional review notes.

docs/ocm/model.md Outdated Show resolved Hide resolved
docs/ocm/model.md Outdated Show resolved Hide resolved
docs/ocm/model.md Outdated Show resolved Hide resolved
docs/ocm/model.md Outdated Show resolved Hide resolved
docs/ocm/model.md Outdated Show resolved Hide resolved
docs/ocm/model.md Outdated Show resolved Hide resolved
docs/ocm/model.md Outdated Show resolved Hide resolved
docs/ocm/model.md Outdated Show resolved Hide resolved
docs/ocm/model.md Show resolved Hide resolved
docs/ocm/modelmapping/s3/README.md Show resolved Hide resolved
@mandelsoft mandelsoft requested a review from a team as a code owner August 15, 2022 13:35
@mandelsoft mandelsoft requested review from Diaphteiros and In-Ko and removed request for a team August 15, 2022 13:35
@Skarlso
Copy link
Contributor

Skarlso commented Aug 16, 2022

Screenshot 2022-08-16 at 7 51 05

@mandelsoft don't know if you saw, but there are a few more remarks that have been hidden. :D

@Skarlso
Copy link
Contributor

Skarlso commented Aug 16, 2022

@In-Ko I think after we finish collaborating on this PR we can merge it and THEN move the things out into the spec repo because this PR contains some minor code changes as well. Are you okay with that?

@mandelsoft
Copy link
Contributor Author

I hope, I have got it all now.

Copy link
Contributor

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM!

@gardener-robot
Copy link
Contributor

@mandelsoft You need rebase this pull request with latest master branch. Please check.

docs/ocm/README.md Outdated Show resolved Hide resolved
docs/ocm/README.md Outdated Show resolved Hide resolved
docs/formats/repositories/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
A transport tool, can use the bill of material to determine the set of
artefacts that have to be transferred and use the access information to access
the technical content of the artefacts in the source environment. They will then
be copied into a repository landscape on the target side. In the target
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
be copied into a repository landscape on the target side. In the target
be copied into a repository on the target side. In the target

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can really be a complete landscape. It is possible to define upload handlers, that upload localBlobs of a dedicated type into any other repository. https://github.com/gardener/ocm/tree/main/pkg/contexts/ocm/blobhandler

docs/ocm/operations.md Outdated Show resolved Hide resolved
pkg/contexts/oci/repositories/ocireg/README.md Outdated Show resolved Hide resolved
pkg/contexts/oci/repositories/ocireg/README.md Outdated Show resolved Hide resolved
pkg/contexts/ocm/repositories/ctf/README.md Show resolved Hide resolved
pkg/contexts/ocm/repositories/ctf/README.md Outdated Show resolved Hide resolved
pkg/contexts/ocm/repositories/ocireg/README.md Outdated Show resolved Hide resolved
pkg/contexts/ocm/repositories/ocireg/README.md Outdated Show resolved Hide resolved
pkg/contexts/ocm/repositories/ocireg/README.md Outdated Show resolved Hide resolved
pkg/contexts/ocm/repositories/ocireg/README.md Outdated Show resolved Hide resolved
pkg/contexts/ocm/repositories/ctf/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/formats/repositories/README.md Outdated Show resolved Hide resolved
docs/formats/repositories/README.md Outdated Show resolved Hide resolved
docs/formats/repositories/README.md Outdated Show resolved Hide resolved
docs/formats/repositories/README.md Outdated Show resolved Hide resolved
@mandelsoft mandelsoft force-pushed the work branch 2 times, most recently from 19497db to b0adf9d Compare August 18, 2022 10:30
@gardener-robot
Copy link
Contributor

@Diaphteiros You have pull request review open invite, please check

@mandelsoft
Copy link
Contributor Author

rebased to resolve conflicts

@jschicktanz jschicktanz self-requested a review August 22, 2022 08:44
@mandelsoft mandelsoft merged commit 06e14e4 into main Aug 24, 2022
@mandelsoft mandelsoft deleted the work branch August 24, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants