fix: go build target with makefile #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `go build` we can't specify more than one binaries to build. Go will not know what to do with them. It feels logical to assume it will build a binary with the same name as the package defined, but 1. You can specify `-o` flag and it can only be one. 2. You can have different modules with the same name like `cmd/mybin` and `extra/mybin`. To prevent polluting the root of the repo, I moved all binary under the `bin/` directory.
|
@yitsushi Thank you for your contribution. |
Skarlso
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
go buildwe can't specify more than one binaries to build. Gowill not know what to do with them. It feels logical to assume it will
build a binary with the same name as the package defined, but
-oflag and it can only be one.cmd/mybinand
extra/mybin.To prevent polluting the root of the repo, I moved all binary under
the
bin/directory.