[WIP] S3 access method for OCM #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Skarlso Thank you for your contribution. |
Skarlso
force-pushed
the
s3_access_method
branch
from
9135cfb to
9f12573
Compare
Skarlso
commented
Aug 4, 2022
| spec: a, | ||
| comp: c, | ||
| accessKeyID: creds.GetProperty(credentials.ATTR_AWS_ACCESS_KEY_ID), | ||
| accessSecret: creds.GetProperty(credentials.ATTR_AWS_SECRET_ACCESS_KEY), |
There was a problem hiding this comment.
Possibly add Session Token to this mix.
Skarlso
commented
Aug 4, 2022
| _, err := accessSpec.AccessMethod(&cpi.DummyComponentVersionAccess{Context: env.OCMContext()}) | ||
| Expect(err).To(MatchError(ContainSubstring("failed to return any credentials; they MUST be provided for s3 access"))) | ||
| }) | ||
| }) |
|
I'dont closed it, may be because I delete the master branch. |
|
We have to make it work without reagin, because the download URL you get from the ui does not need a region. |
|
I've cherry picked the content and update the branch |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR will be rebased once #36 is merged. I'll also refactor the testing resources ( the way I'm mocking credentials ) and possibly unify some overlapping things.
What this PR does / why we need it:
Creates an access method for OCM.
Which issue(s) this PR fixes:
Fixes #40
Special notes for your reviewer:
Release note: