Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add creationTime attribute #235

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Conversation

mandelsoft
Copy link
Contributor

@mandelsoft mandelsoft commented Jan 12, 2023

What this PR does / why we need it:

It adds an optional creationTimestamp field to the object meta information.

It uses a format according to RFC3339.

The creation time will be set by the CLI commands creating component versions.
For a library user, the timestamp has to explicitly be added to the component descriptor when
creating a new version.

Correlates to ocm-spec PR#49.

Which issue(s) this PR fixes:
F[ixes #48

Special notes for your reviewer:

Release note:

@In-Ko In-Ko self-requested a review January 13, 2023 14:42
@In-Ko
Copy link
Member

In-Ko commented Jan 16, 2023

  • Proper documentation of the new element CreationDate is missing (in the OCM and OCM-Spec docs)
  • Only one JSON-Schema has been adjusted (the one in the OCM Repo). But there is another one in the OCM-Spec Repo.
    • The OCM-Spec Schema also needs to be changed
    • This begs the question: Why do we have two separate JSON-Schema anyway ? Is that really necessary ? (If we want do change this, we should do this in another PR though ...)

@mandelsoft
Copy link
Contributor Author

mandelsoft commented Jan 16, 2023

Aligned spec with PR#49

@In-Ko
Copy link
Member

In-Ko commented Jan 17, 2023

In-Ko
In-Ko previously approved these changes Jan 17, 2023
Copy link
Member

@In-Ko In-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mandelsoft mandelsoft merged commit 6efb44d into open-component-model:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add (creation?) timestamp to component-descriptor-spec
2 participants