Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove CRD definition for the Component Descriptor #176

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

yitsushi
Copy link
Contributor

@yitsushi yitsushi commented Nov 7, 2022

Copy link
Contributor

@mandelsoft mandelsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand it correctly, the new CRD types in the controller repo do not use the metav1 types from the ocm library component descriptor package anymore?

So, the OCM CD functions cannot be used with the CD part of the CRD spec anymore?

@Skarlso
Copy link
Contributor

Skarlso commented Nov 7, 2022

Do I understand it correctly, the new CRD types in the controller repo do not use the metav1 types from the ocm library component descriptor package anymore?

They do use it. The controllers import the OCM library. It's the same spec but lives in a different repo where the usage is clearer.

@mandelsoft
Copy link
Contributor

Thanks, I was just asking, because the kubebilder annotations have been removed from the metav1 structs. I thought, they were required for the usage of those types in CRD definitions.

@yitsushi yitsushi merged commit 25501ad into main Nov 8, 2022
@Skarlso
Copy link
Contributor

Skarlso commented Nov 8, 2022

Thanks, I was just asking, because the kubebilder annotations have been removed from the metav1 structs. I thought, they were required for the usage of those types in CRD definitions.

That's a good point. It does work, I also thought it was required. :) I'll double check.

@mandelsoft mandelsoft deleted the 171-remove-crd-def branch December 21, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear out the ComponentDescriptor api definition from this repository
3 participants