Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

differentiate between docker repository name and hostname #162

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

mandelsoft
Copy link
Contributor

What this PR does / why we need it:

The legacy notation for dockerhub based references uses a name restriction for the repository
which can be used to differentiate between dockerhub references and flat image names stored in some
other OCI registry.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Copy link
Contributor

@yitsushi yitsushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, it can't contain (on dockerhub) repeated special characters.

image

image

image

And . is allowed too.

image

So this is a valid name: a.0-b_1

image

@mandelsoft mandelsoft merged commit 3cb5eb8 into open-component-model:main Oct 26, 2022
@mandelsoft mandelsoft deleted the docker branch October 26, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants