-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch workflow trigger to pull_request_target #132
Conversation
b946ce7
to
cbaf043
Compare
strange, now it is not running for local PRs. Should I add both events? |
I would try:
on: [pull_request, push] push: run on all commits, it's good in general because that way it will be executed on main after merge too and it's easy to re-trigger the PR checker by force-pushing the same commit ( |
cbaf043
to
05e3355
Compare
It's running \o/ the PR checkers are running |
Done, but now we have the execution twice |
1 similar comment
Done, but now we have the execution twice |
05e3355
to
ceaa2a8
Compare
What this PR does / why we need it:
According to the Github Action Docu
the trigger option for the linter and test workflow should be set to
pull_request_target
to run the workflow for PRs originating from forks based on the workflow definition of the base branch, instead of the provided content.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: