Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "switch to string compare function in test" #131

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Revert "switch to string compare function in test" #131

merged 1 commit into from
Oct 3, 2022

Conversation

yitsushi
Copy link
Contributor

@yitsushi yitsushi commented Oct 3, 2022 •
edited
Loading

Reverts #128

That PR shouldn't be merged:

  1. It had only one review, PR settings: "At least 2 approving reviews are required by reviewers with write access"
  2. PR checks did not run, maybe it's a configuration error and it's not running from forks. In this case we have to fix that too.

I had a lot of comment, but I did not have the opportunity because it was merged right after the PR got one review (instead of 2)

@yitsushi
Copy link
Contributor Author

yitsushi commented Oct 3, 2022 •
edited
Loading

I have no idea why GitHub allowed to merge it with one review only (if no one changed settings and changed back, or someone with god privileges has the option to merge something even if it has only one or zero reviews).

@yitsushi yitsushi merged commit e4323bd into main Oct 3, 2022
@mandelsoft mandelsoft deleted the revert-128-tests branch December 21, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoban01 phoban01 phoban01 approved these changes

@Skarlso Skarlso Skarlso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yitsushi @Skarlso @phoban01