Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library doc: How to work with credentials and configurations #122

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

mandelsoft
Copy link
Contributor

@mandelsoft mandelsoft commented Sep 26, 2022

What this PR does / why we need it:
This PR provides some docs and examples how to work with credentials and configurations

Unfortunately the base commit was not formatted correctly, therefore more files are affected than explicitly modified.

Additionally, to make the example more consistent, some constants have been renamed and/or moved.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@mandelsoft mandelsoft changed the title library doc: credentials library doc: How to work with credentials Sep 26, 2022
@jschicktanz jschicktanz self-requested a review September 26, 2022 13:32
examples/lib/creds.md Outdated Show resolved Hide resolved
examples/lib/creds.md Outdated Show resolved Hide resolved
examples/lib/creds.md Outdated Show resolved Hide resolved
examples/lib/creds.md Outdated Show resolved Hide resolved
examples/lib/creds.md Outdated Show resolved Hide resolved
examples/lib/creds.md Outdated Show resolved Hide resolved
examples/lib/creds.md Outdated Show resolved Hide resolved
examples/lib/creds.md Outdated Show resolved Hide resolved
examples/lib/creds.md Outdated Show resolved Hide resolved
examples/lib/creds.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jschicktanz jschicktanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor remarks

@mandelsoft mandelsoft changed the title library doc: How to work with credentials library doc: How to work with credentials and configurations Sep 27, 2022
jschicktanz
jschicktanz previously approved these changes Sep 30, 2022
@mandelsoft
Copy link
Contributor Author

Please Resolve the review issues, if my changes/comment are acceptable.

Skarlso
Skarlso previously approved these changes Oct 3, 2022
jensh007
jensh007 previously approved these changes Oct 5, 2022
Skarlso
Skarlso previously approved these changes Oct 6, 2022
@mandelsoft mandelsoft dismissed stale reviews from Skarlso and jensh007 via 1e93d0f October 6, 2022 12:11
@mandelsoft
Copy link
Contributor Author

Sorry about this, but I had to fix a merge conflict before merging.

@mandelsoft mandelsoft requested review from jensh007 and Skarlso October 6, 2022 12:15
jensh007
jensh007 previously approved these changes Oct 6, 2022
Skarlso
Skarlso previously approved these changes Oct 6, 2022
incorporate feedback

add examples for config context

add example cred.yaml file
@mandelsoft mandelsoft dismissed stale reviews from Skarlso and jensh007 via 2f3eac7 October 6, 2022 16:58
@mandelsoft
Copy link
Contributor Author

Somebody else was faster again.
I just squashed the changes and then rebased to the actual main.
But I need again the approvals, sorry.

@mandelsoft mandelsoft requested review from Skarlso and jensh007 October 6, 2022 17:01
@mandelsoft mandelsoft merged commit 65e8855 into open-component-model:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants