Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct fetch order for manifests and blobs with hints on media type #1209

Merged
merged 9 commits into from
Dec 20, 2024
Merged

fix: correct fetch order for manifests and blobs with hints on media type #1209

merged 9 commits into from
Dec 20, 2024

Conversation

jakobmoellerdev
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev commented Dec 19, 2024 •
edited
Loading

What this PR does / why we need it

This PR changes the OCI fetch logic to:

  1. Fetch Blobs before Manifests in case there is no media type
  2. Fetch Manifests before Blobs or Blobs before Manifests if there is a media type hint

Which issue(s) this PR fixes

@github-actions github-actions bot added kind/chore chore, maintenance, etc. size/xs Extra small labels Dec 19, 2024
@github-actions github-actions bot added component/ocm-cli OCM Command Line Interface size/s Small and removed size/xs Extra small labels Dec 19, 2024
@jakobmoellerdev jakobmoellerdev force-pushed the chore/close-out-of-desparation branch from 8f93370 to 14aa04f Compare December 19, 2024 17:21
@github-actions github-actions bot added the kind/dependency dependency update, etc. label Dec 19, 2024
@github-actions github-actions bot added size/m Medium and removed size/s Small labels Dec 19, 2024
@jakobmoellerdev jakobmoellerdev force-pushed the chore/close-out-of-desparation branch from b49bec3 to 8174744 Compare December 20, 2024 12:23
@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review December 20, 2024 12:28
@jakobmoellerdev jakobmoellerdev requested a review from a team as a code owner December 20, 2024 12:28
@jakobmoellerdev jakobmoellerdev changed the title chore: close out of desparation fix: correct fetch order for manifests and blobs with hints on media type Dec 20, 2024
@github-actions github-actions bot added the kind/bugfix Bug label Dec 20, 2024
@jakobmoellerdev jakobmoellerdev removed the kind/chore chore, maintenance, etc. label Dec 20, 2024
@jakobmoellerdev jakobmoellerdev merged commit 285a20a into open-component-model:main Dec 20, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skarlso Skarlso Skarlso approved these changes

Assignees
No one assigned
Labels
component/ocm-cli OCM Command Line Interface kind/bugfix Bug kind/dependency dependency update, etc. size/m Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakobmoellerdev @Skarlso