chore: fixup release action versioning and notes process #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng a separate branch
github-actions
bot
added
chore
component/github-actions
jakobmoellerdev
force-pushed
the
chore/fixup-release-notes-and-versions
branch
3 times, most recently
from
ac49421 to
853c57b
Compare
hilmarf
reviewed
Nov 22, 2024
hilmarf
reviewed
Nov 22, 2024
hilmarf
reviewed
Nov 22, 2024
hilmarf
reviewed
Nov 22, 2024
hilmarf
previously approved these changes
Nov 22, 2024
There was a problem hiding this comment.
you're planning to get rid of the individual makefiles sooner or later, right?
Otherwise it might be worth thinking of using include ... ?
frewilhelm
reviewed
Nov 22, 2024
jakobmoellerdev
force-pushed
the
chore/fixup-release-notes-and-versions
branch
from
853c57b to
3813f0a
Compare
@hilmarf Currently unplanned, but we can create an issue for this so I can take care of it. I would really like to just get the releases working right now. |
hilmarf
reviewed
Nov 22, 2024
hilmarf
reviewed
Nov 22, 2024
hilmarf
reviewed
Nov 22, 2024
hilmarf
previously approved these changes
Nov 22, 2024
otherwise the components in the CTF will still be flagged as dev if used from the release flow
jakobmoellerdev
force-pushed
the
chore/fixup-release-notes-and-versions
branch
from
3813f0a to
00f33d5
Compare
hilmarf
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Makes sure that release notes are correctly drawn in and that we always have the version set correctly in our CTFs.
Which issue(s) this PR fixes
This fixes up the release action in 2 important ways:
VERSIONvariable whileEFFECTIVE_VERSIONis a combination of VERSION+COMMIT by default. I didnt want to change this behavior originally, so now I started to use VERSION for the Makefiles (which also means I had to export them as settable). This now leads to correct CTF versionsv0.19.0-rc.1instead ofv0.19.0-devfor example.As such its a follow up from #1120 and #1077