chore: ensure that PR titles must be semantic #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enforces Semantic Pull Request titles: - see https://github.com/amannn/action-semantic-pull-request?tab=readme-ov-file#examples for examples - see https://www.conventionalcommits.org/en/v1.0.0/#specification for the full specification We want this because we use squashing so all squashed commits should conform to our commit style
|
Sample run of title failure: https://github.com/open-component-model/ocm-cicd-playground/actions/runs/11911808386/job/33194099938 |
|
https://github.com/open-component-model/ocm/actions/runs/11913289589/job/33198678380?pr=1108 fails because there was a typo in the label config and it checks for |
hilmarf
approved these changes
Nov 19, 2024
Skarlso
approved these changes
Nov 19, 2024
jakobmoellerdev
merged commit 43c9c16
into
open-component-model:main
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This enforces Semantic Pull Request titles:
We want this because we use squashing so all squashed commits should conform to our commit style
Which issue(s) this PR fixes