chore: cleanup release action #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves Version Generation into a separate workflow for readability reasons. Removes option to create release branch in release.yaml as it is a separate branch cut step.
…cleanup-release-versioning # Conflicts: # .github/workflows/release.yaml
|
A partial run of the changes can be observed here: https://github.com/open-component-model/ocm-cicd-playground/actions/runs/11783730801 (cancelled before publish to avoid artifacts being pushed) |
hilmarf
reviewed
Nov 12, 2024
hilmarf
previously approved these changes
Nov 12, 2024
hilmarf
added
component/github-actions
hilmarf
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This fixes several inconsistencies with the release action and cleans it up before we are migrating some of the more substantial work within it:
ghinstead of the oldcardinalby/git-get-release-action@v1because it is much faster and transparent what happens and the action wasn't maintained properly.prereleaseflag was renamed torelease_candidate_nameto make it more clear for what it is actually used in the code. The existing docs on the action one can see when triggering them are unchangedcreate_branchoption is killed because we dont expect the release to trigger the release branch creation, we expect that to come before. A separate PR can trigger the first release candidate creation from the Branch cutoff however (this will come separately)Which issue(s) this PR fixes
Part of the release process and transparency rework in #995