Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow publishing to Brew via custom script #1059

Conversation

jakobmoellerdev
Copy link
Contributor

What this PR does / why we need it

Part of the release rework (#995) that will allow us to move away from goreleaser for actual release work. This fully replaces the goreleaser workflow of updating the brew TAP with a PR that creates a versioned link in a PR towards the TAP repository. This allows

  • versioned brew installations like brew install open-component-model/tap/[email protected] instead of just the latest release
  • Allows us to run the goreleaser process without ever publishing any artifact externally

Which issue(s) this PR fixes

@github-actions github-actions bot added the chore label Nov 7, 2024
@jakobmoellerdev jakobmoellerdev force-pushed the chore/versioned-brew-no-goreleaser branch from 2329908 to 07762c4 Compare November 7, 2024 15:38
Copy link
Contributor

@frewilhelm frewilhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.. however, some unit tests for hack/brew/main.go could be beneficial

.github/workflows/publish-to-other-than-github.yaml Outdated Show resolved Hide resolved
@jakobmoellerdev jakobmoellerdev force-pushed the chore/versioned-brew-no-goreleaser branch from 47de1ca to 0890356 Compare November 8, 2024 10:13
hilmarf
hilmarf previously approved these changes Nov 8, 2024
Copy link
Member

@hilmarf hilmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hilmarf hilmarf added this to the 2024-Q4 milestone Nov 8, 2024
@jakobmoellerdev
Copy link
Contributor Author

Not fully tested yet need to verify a PR creation

@jakobmoellerdev jakobmoellerdev force-pushed the chore/versioned-brew-no-goreleaser branch from 0890356 to cfa7ad6 Compare November 8, 2024 19:19
@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review November 8, 2024 19:23
@jakobmoellerdev jakobmoellerdev requested a review from a team as a code owner November 8, 2024 19:23
@jakobmoellerdev jakobmoellerdev force-pushed the chore/versioned-brew-no-goreleaser branch from cfa7ad6 to c666541 Compare November 8, 2024 19:25
@jakobmoellerdev jakobmoellerdev force-pushed the chore/versioned-brew-no-goreleaser branch from c666541 to 7ac8605 Compare November 8, 2024 19:27
@jakobmoellerdev jakobmoellerdev added the component/github-actions Changes on GitHub Actions or within `.github/` directory label Nov 8, 2024
@hilmarf
Copy link
Member

hilmarf commented Nov 11, 2024

We'll need some follow up tasks for the brew-tap-repo. Branch-protection-rules? Codeowners file for automated review assignments...

@jakobmoellerdev
Copy link
Contributor Author

I will have to think about this some more, but technically these stories were always needed but we never got around to it right?

@jakobmoellerdev jakobmoellerdev merged commit edacaa2 into open-component-model:main Nov 11, 2024
17 checks passed
@jakobmoellerdev
Copy link
Contributor Author

I created a Ruleset for now at least in evaluation mode, will follow up with some more stories right after

@hilmarf
Copy link
Member

hilmarf commented Nov 11, 2024

I've copy & pasted now the codeowners file from ocm, so that new PRs in brew-tap are not missed and automatically assigned to 'Maintainers'

@hilmarf hilmarf added the kind/chore chore, maintenance, etc. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/github-actions Changes on GitHub Actions or within `.github/` directory kind/chore chore, maintenance, etc.
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

3 participants