-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow publishing to Brew via custom script #1059
chore: allow publishing to Brew via custom script #1059
Conversation
2329908
to
07762c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.. however, some unit tests for hack/brew/main.go
could be beneficial
47de1ca
to
0890356
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not fully tested yet need to verify a PR creation |
0890356
to
cfa7ad6
Compare
cfa7ad6
to
c666541
Compare
c666541
to
7ac8605
Compare
We'll need some follow up tasks for the brew-tap-repo. Branch-protection-rules? Codeowners file for automated review assignments... |
I will have to think about this some more, but technically these stories were always needed but we never got around to it right? |
I created a Ruleset for now at least in evaluation mode, will follow up with some more stories right after |
I've copy & pasted now the codeowners file from ocm, so that new PRs in brew-tap are not missed and automatically assigned to 'Maintainers' |
What this PR does / why we need it
Part of the release rework (#995) that will allow us to move away from goreleaser for actual release work. This fully replaces the goreleaser workflow of updating the brew TAP with a PR that creates a versioned link in a PR towards the TAP repository. This allows
brew install open-component-model/tap/[email protected]
instead of just the latest releaseWhich issue(s) this PR fixes