Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component constructor with references field #1054

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

mandelsoft
Copy link
Contributor

@mandelsoft mandelsoft commented Nov 5, 2024

What this PR does / why we need it

The component constructor used the field componentReferences from the v2 version of the component descriptor.
in v3 this has been corrected to references (it described component version references and no component references).
This should reflected in the constructor files, also.

the old field is now deprecated (but still works). Instead, the field references is supported, now.
It is not possible to use both fields at the same time.

Which issue(s) this PR fixes

Fixes #1041

@mandelsoft mandelsoft requested a review from a team as a code owner November 5, 2024 12:14
@mandelsoft mandelsoft requested a review from morri-son November 5, 2024 12:44
@hilmarf hilmarf added this to the 2024-Q4 milestone Nov 5, 2024
@jakobmoellerdev jakobmoellerdev merged commit 9e27f16 into open-component-model:main Nov 6, 2024
15 checks passed
@mandelsoft mandelsoft deleted the compose branch November 6, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

Cannot add references in component-constructor.yaml file as part of component version specification
3 participants