-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reuse aggregation from ctf during component build #1044
Merged
hilmarf
merged 8 commits into
open-component-model:main
from
jakobmoellerdev:chore/reuse-aggregation-from-ctf
Nov 6, 2024
Merged
chore: reuse aggregation from ctf during component build #1044
hilmarf
merged 8 commits into
open-component-model:main
from
jakobmoellerdev:chore/reuse-aggregation-from-ctf
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobmoellerdev
force-pushed
the
chore/reuse-aggregation-from-ctf
branch
5 times, most recently
from
November 4, 2024 14:45
7dee0dd
to
be41fc6
Compare
jakobmoellerdev
force-pushed
the
chore/reuse-aggregation-from-ctf
branch
3 times, most recently
from
November 4, 2024 15:48
2833af7
to
1b9db60
Compare
jakobmoellerdev
force-pushed
the
chore/reuse-aggregation-from-ctf
branch
4 times, most recently
from
November 4, 2024 17:02
11c700e
to
56b81c5
Compare
jakobmoellerdev
force-pushed
the
chore/reuse-aggregation-from-ctf
branch
from
November 4, 2024 17:25
56b81c5
to
7131f04
Compare
…e-explicit # Conflicts: # Makefile # components/demoplugin/Makefile # components/ecrplugin/Makefile # components/ocmcli/Makefile
jakobmoellerdev
changed the title
chor: reuse aggregation from ctf during component build
chore: reuse aggregation from ctf during component build
Nov 4, 2024
jakobmoellerdev
force-pushed
the
chore/reuse-aggregation-from-ctf
branch
5 times, most recently
from
November 5, 2024 11:35
8917573
to
bd69df5
Compare
jakobmoellerdev
force-pushed
the
chore/reuse-aggregation-from-ctf
branch
from
November 5, 2024 11:44
bd69df5
to
e0d2987
Compare
Note to Reviewer: I have to change the PR rules due to the changed Job names after this goes in |
This avoids having to rebuild the CLI while we still do not have it here (its only in the CTF and not available as a binary)
hilmarf
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - what a pity, that the aggregation again requires go-setup etc.
hilmarf
added
component/github-actions
Changes on GitHub Actions or within `.github/` directory
chore 🔨
labels
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/github-actions
Changes on GitHub Actions or within `.github/` directory
kind/chore
chore, maintenance, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
this will create an aggregation post build that can be reused during releases if necessary
Which issue(s) this PR fixes
This is a revision of the component build in preparation to reuse the final CTF artifacts during our release