Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reuse aggregation from ctf during component build #1044

Conversation

jakobmoellerdev
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev commented Nov 4, 2024

What this PR does / why we need it

this will create an aggregation post build that can be reused during releases if necessary

Which issue(s) this PR fixes

This is a revision of the component build in preparation to reuse the final CTF artifacts during our release

@github-actions github-actions bot added the chore label Nov 4, 2024
@jakobmoellerdev jakobmoellerdev force-pushed the chore/reuse-aggregation-from-ctf branch 5 times, most recently from 7dee0dd to be41fc6 Compare November 4, 2024 14:45
@jakobmoellerdev jakobmoellerdev force-pushed the chore/reuse-aggregation-from-ctf branch 3 times, most recently from 2833af7 to 1b9db60 Compare November 4, 2024 15:48
@jakobmoellerdev jakobmoellerdev force-pushed the chore/reuse-aggregation-from-ctf branch 4 times, most recently from 11c700e to 56b81c5 Compare November 4, 2024 17:02
@jakobmoellerdev jakobmoellerdev force-pushed the chore/reuse-aggregation-from-ctf branch from 56b81c5 to 7131f04 Compare November 4, 2024 17:25
…e-explicit

# Conflicts:
#	Makefile
#	components/demoplugin/Makefile
#	components/ecrplugin/Makefile
#	components/ocmcli/Makefile
@jakobmoellerdev jakobmoellerdev changed the title chor: reuse aggregation from ctf during component build chore: reuse aggregation from ctf during component build Nov 4, 2024
@jakobmoellerdev jakobmoellerdev force-pushed the chore/reuse-aggregation-from-ctf branch 5 times, most recently from 8917573 to bd69df5 Compare November 5, 2024 11:35
@jakobmoellerdev jakobmoellerdev force-pushed the chore/reuse-aggregation-from-ctf branch from bd69df5 to e0d2987 Compare November 5, 2024 11:44
@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review November 5, 2024 12:04
@jakobmoellerdev jakobmoellerdev requested a review from a team as a code owner November 5, 2024 12:04
@jakobmoellerdev
Copy link
Contributor Author

Note to Reviewer: I have to change the PR rules due to the changed Job names after this goes in

This avoids having to rebuild the CLI while we still do not have it here (its only in the CTF and not available as a binary)
Copy link
Member

@hilmarf hilmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - what a pity, that the aggregation again requires go-setup etc.

@hilmarf hilmarf added this to the 2024-Q4 milestone Nov 6, 2024
@hilmarf hilmarf added component/github-actions Changes on GitHub Actions or within `.github/` directory chore 🔨 labels Nov 6, 2024
@hilmarf hilmarf merged commit 2188c1c into open-component-model:main Nov 6, 2024
17 checks passed
@hilmarf hilmarf added the kind/chore chore, maintenance, etc. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/github-actions Changes on GitHub Actions or within `.github/` directory kind/chore chore, maintenance, etc.
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

2 participants