fix artifact set tagging #1033
Merged
fix artifact set tagging #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobmoellerdev
approved these changes
Nov 6, 2024
jakobmoellerdev
added a commit
that referenced
this pull request
Nov 12, 2024
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it PR #1033 introduced a split of the OCI version info from the repository part. The method `Version` checks the inverted condition for an existing version inf. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> --------- Co-authored-by: Jakob Möller <[email protected]>
jakobmoellerdev
added a commit
to jakobmoellerdev/ocm
that referenced
this pull request
Nov 12, 2024
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it PR open-component-model#1033 introduced a split of the OCI version info from the repository part. The method `Version` checks the inverted condition for an existing version inf. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> --------- Co-authored-by: Jakob Möller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Because the new OCI references now always contain the digest in addition to the tag, the artifactset creation
is not able anymore to provide appropriate meta data.
This is fixed by a new ArtVersion type able to handle the combination of digest and tag.
Which issue(s) this PR fixes