--help broke

[Skarlso]

For any command when I'm trying to run --help I get:

ocm add --help
ocm add — template: top:1:29: executing "top" at <.Short>: wrong type for value; expected language.Tag; got string

[mandelsoft]

This must have been those golangci-lint proposals

[mandelsoft]

. /home/d021770/dev/go/landscaper/src/github.com/open-component-model/ocm/pkg/...
WARN [linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649. 
cmds/ocm/pkg/cobrautils/funcs.go:25:17: SA1019: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (staticcheck)
	"title":       strings.Title,
	               ^

This is not a replacement

[mandelsoft]

No idea how to use it. Could you fix this?

[Skarlso]

Yep, on it.

[mandelsoft]

I think strings.Title should be replaced by cases.Title(language.English).String

[Skarlso]

That's not the cause of the broken --help though. Don't worry, I'll fix it. :)

[mandelsoft]

sure, after I changed this, help worked again

[Skarlso]

What was your change? Because for me it still fails.

[Skarlso]

I might be missing something but that strings.Title is generate-docs, right? That's not part of the help generating problem.

[Skarlso]

ah you mean what you replaced here:

var templatefuncs = map[string]interface{}{
	"indent":      indent,
	"skipCommand": skipCommand,
	"soleCommand": soleCommand,
-	"title":       strings.Title,
+	"title":       cases.Title,
}

[Skarlso]

Yep, that works.