Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ocmcli to v0.7.0 #184

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Update ocmcli to v0.7.0 #184

merged 2 commits into from
Mar 7, 2024

Conversation

hilmarf
Copy link
Member

@hilmarf hilmarf commented Mar 7, 2024

bump versions:

  • ocm v0.7.0
  • cobra v1.8.0
  • exp v0.0.0-20231006

Description

fixes: #183

Once it's merged the github action `` should work again and when triggered, creates a new PR to update the OCM-commandline-interface docs.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

ocm v0.7.0
cobra v1.8.0
exp v0.0.0-20231006
@hilmarf hilmarf requested a review from morri-son March 7, 2024 07:47
@hilmarf hilmarf enabled auto-merge (squash) March 7, 2024 07:50
Update OCM CLI documentation for new release

Co-authored-by: hilmarf <[email protected]>
Copy link
Contributor

@morri-son morri-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hilmarf hilmarf merged commit 6f63c6d into main Mar 7, 2024
3 checks passed
@hilmarf hilmarf deleted the fix/183 branch March 7, 2024 09:42
@morri-son
Copy link
Contributor

Hi @hilmarf, I'm not able to run the webpage locally anymore. This should work using

npm run start

Trying this now I get

❯ npm run start

> [email protected] prestart
> npm run clean


> [email protected] clean
> shx rm -rf public resources


> [email protected] start
> exec-bin node_modules/.bin/hugo/hugo server --bind=0.0.0.0 --disableFastRender

node:events:497
      throw er; // Unhandled 'error' event
      ^

Error: spawn node_modules/.bin/hugo/hugo ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:286:19)
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Emitted 'error' event on ChildProcess instance at:
    at ChildProcess._handle.onexit (node:internal/child_process:292:12)
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn node_modules/.bin/hugo/hugo',
  path: 'node_modules/.bin/hugo/hugo',
  spawnargs: [ 'server', '--bind=0.0.0.0', '--disableFastRender' ]
}

Node.js v21.7.0

Can you please try this out on your laptop? I just installed a new node.js version and also she, so the issue may be related to this, too.

@hilmarf
Copy link
Member Author

hilmarf commented Mar 8, 2024

Hi @hilmarf, I'm not able to run the webpage locally anymore. This should work using

npm run start

Trying this now I get

❯ npm run start

> [email protected] prestart
> npm run clean


> [email protected] clean
> shx rm -rf public resources


> [email protected] start
> exec-bin node_modules/.bin/hugo/hugo server --bind=0.0.0.0 --disableFastRender

node:events:497
      throw er; // Unhandled 'error' event
      ^

Error: spawn node_modules/.bin/hugo/hugo ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:286:19)
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Emitted 'error' event on ChildProcess instance at:
    at ChildProcess._handle.onexit (node:internal/child_process:292:12)
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn node_modules/.bin/hugo/hugo',
  path: 'node_modules/.bin/hugo/hugo',
  spawnargs: [ 'server', '--bind=0.0.0.0', '--disableFastRender' ]
}

Node.js v21.7.0

Can you please try this out on your laptop? I just installed a new node.js version and also she, so the issue may be related to this, too.

@morri-son
Please give it a try with the latest LTS version of node v20.11.1

I believe I was running the site yesterday successfully with that version

@morri-son
Copy link
Contributor

yup, that was the issue! Thanks, works now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

Action for generation of linked docs from OCM CLI fails
2 participants