Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mpas section #136

Merged
merged 14 commits into from
Sep 22, 2023
Merged

Create mpas section #136

merged 14 commits into from
Sep 22, 2023

Conversation

souleb
Copy link
Contributor

@souleb souleb commented Sep 12, 2023

What this PR does / why we need it:

If implemented this will add a mpas section that explains how to install and get started with mpas.

Which issue(s) this PR fixes:
Fixes #137

Special notes for your reviewer:

Release note:

@souleb souleb marked this pull request as draft September 12, 2023 14:33
If implemented this will add a mpas section that explains how to
install and get started with mpas.

Signed-off-by: Soule BA <[email protected]>
@souleb souleb marked this pull request as ready for review September 20, 2023 10:17
Copy link
Contributor

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions and changes in wording.

Great work for writing all this down!

content/en/mpas/getting_started.md Outdated Show resolved Hide resolved
content/en/mpas/getting_started.md Outdated Show resolved Hide resolved
content/en/mpas/getting_started.md Outdated Show resolved Hide resolved
content/en/mpas/getting_started.md Outdated Show resolved Hide resolved
content/en/mpas/getting_started.md Outdated Show resolved Hide resolved
content/en/mpas/getting_started.md Outdated Show resolved Hide resolved
content/en/mpas/getting_started.md Outdated Show resolved Hide resolved
content/en/mpas/getting_started.md Outdated Show resolved Hide resolved
content/en/mpas/getting_started.md Outdated Show resolved Hide resolved
content/en/mpas/overview/installation.md Outdated Show resolved Hide resolved
content/en/mpas/core_concepts.md Outdated Show resolved Hide resolved
content/en/mpas/core_concepts.md Outdated Show resolved Hide resolved
content/en/mpas/core_concepts.md Show resolved Hide resolved
content/en/mpas/core_concepts.md Outdated Show resolved Hide resolved
content/en/mpas/core_concepts.md Outdated Show resolved Hide resolved
Copy link
Contributor

@phoban01 phoban01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good @souleb.

Just a few nits from me.

content/en/mpas/core_concepts.md Outdated Show resolved Hide resolved
content/en/mpas/core_concepts.md Outdated Show resolved Hide resolved
content/en/mpas/core_concepts.md Outdated Show resolved Hide resolved
content/en/mpas/getting_started.md Outdated Show resolved Hide resolved
content/en/mpas/getting_started.md Outdated Show resolved Hide resolved
@souleb
Copy link
Contributor Author

souleb commented Sep 22, 2023

all the TODOs have now corresponding issues so I removed them.

@souleb souleb merged commit aa91860 into main Sep 22, 2023
3 checks passed
@morri-son morri-son deleted the mpas-section branch March 25, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create mpas documentation
4 participants