Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource reconcile failed due to missing url in status #226

Closed
dee0 opened this issue Jul 11, 2024 · 1 comment · Fixed by open-component-model/ocm-controller#493
Closed
Assignees
Labels
kind/bugfix Bug kind/task small task, normally part of feature or epic

Comments

@dee0
Copy link

dee0 commented Jul 11, 2024

What happened:

Reconcile of Resource object failed with
"failed to look up component Version: failed to do request: Head \"https://component-descriptors/v2/dmi.csi.sap/dmi-broker/manifests/1.3.0-1126.xb2559b5.17\": dial tcp: lookup component-descriptors on 100.64.0.10:53: no such host",

ResourceReconciler:reconcile gets this when it is trying to get the resource. This is happening because cv.Status.ReplicatedRepositoryURL is empty string.

What you expected to happen:

Reconcile to work

How to reproduce it (as minimally and precisely as possible):

See discussion here

Anything else we need to know:

Environment:

See discussion here

@dee0 dee0 added kind/bugfix Bug kind/task small task, normally part of feature or epic labels Jul 11, 2024
@Skarlso Skarlso moved this from 🆕 ToDo to 🔍 Review in OCM Backlog Board Jul 15, 2024
@Skarlso Skarlso moved this from 🔍 Review to 🏗 In Progress in OCM Backlog Board Jul 15, 2024
@Skarlso Skarlso self-assigned this Jul 15, 2024
@Skarlso
Copy link
Contributor

Skarlso commented Jul 15, 2024

Strange. 🤔 It shouldn't have gotten into this situation since it only tries to deal with component versions that are READY. And all ready component versions have this URL set.

In any case I'll add an error and reconcile.

Skarlso added a commit to open-component-model/ocm-controller that referenced this issue Jul 16, 2024
## Description

Fix open-component-model/ocm-project#226


## What type of PR is this? (check all applicable)

- [ ] 🍕 Feature
- [ ] 🐛 Bug Fix
- [ ] 📝 Documentation Update
- [ ] 🎨 Style
- [ ] 🧑‍💻 Code Refactor
- [ ] 🔥 Performance Improvements
- [ ] ✅ Test
- [ ] 🤖 Build
- [ ] 🔁 CI
- [ ] 📦 Chore (Release)
- [ ] ⏩ Revert

## Related Tickets & Documents

<!-- 
Please use this format link issue numbers: Fixes #123

https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->
- Related Issue # (issue)
- Closes # (issue)
- Fixes # (issue)
> Remove if not applicable

## Screenshots

<!-- Visual changes require screenshots -->


## Added tests?

- [ ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help
- [ ] Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration


## Added to documentation?

- [ ] 📜 README.md
- [ ] 🙅 no documentation needed

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to 🍺 Done in OCM Backlog Board Jul 16, 2024
@ocmbot ocmbot bot moved this from 🍺 Done to 🔒Closed in OCM Backlog Board Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bugfix Bug kind/task small task, normally part of feature or epic
Projects
Status: 🔒Closed
Development

Successfully merging a pull request may close this issue.

2 participants